Add Selenium regression test for list audit detail#3048
Open
labkey-bpatel wants to merge 1 commit into
Open
Conversation
4 tasks
labkey-nicka
approved these changes
Jun 16, 2026
| } | ||
|
|
||
| /** | ||
| * CWE-639 (IDOR): a list audit event loaded by user-controlled rowId in |
Contributor
There was a problem hiding this comment.
nit: This comment could just be a reference to the kanban issue.
labkey-tchad
approved these changes
Jun 16, 2026
Comment on lines
+885
to
+888
| _listHelper.createList(getProjectName(), LIST_X, "Key", | ||
| new FieldDefinition(NAME_FIELD, ColumnType.String)); | ||
| _listHelper.createList(getProjectName(), LIST_Y, "Key", | ||
| new FieldDefinition(NAME_FIELD, ColumnType.String)); |
Member
There was a problem hiding this comment.
Using the ListHelper to create the lists adds a bunch of unnecessary UI interaction. The API helper will speed this up a ton.
Suggested change
| _listHelper.createList(getProjectName(), LIST_X, "Key", | |
| new FieldDefinition(NAME_FIELD, ColumnType.String)); | |
| _listHelper.createList(getProjectName(), LIST_Y, "Key", | |
| new FieldDefinition(NAME_FIELD, ColumnType.String)); | |
| Connection connection = createDefaultConnection(); | |
| new IntListDefinition(LIST_X, "Key") | |
| .addField(new FieldDefinition(NAME_FIELD, ColumnType.String)) | |
| .create(connection, getProjectName()); | |
| new IntListDefinition(LIST_Y, "Key") | |
| .addField(new FieldDefinition(NAME_FIELD, ColumnType.String)) | |
| .create(connection, getProjectName()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
OWASP Finding:
_listcontainer-resolved, but rendered old/new maps fromAuditLogService.getAuditEvent(user, LIST_AUDIT_EVENT, rowId)global (cf=null); event never tied to list,event.getContainer()uncheckedSee Related PR
Related Pull Requests
Changes
Tasks 📍